Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to rehype remove images #145

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

iloveitaly
Copy link
Contributor

@iloveitaly iloveitaly commented Jul 17, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

adding link to new plugin

ref: rehypejs/rehype-minify#47

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jul 17, 2023
@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7d0d0e4) 100.00% compared to head (25d1a9d) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #145   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          461       461           
=========================================
  Hits           461       461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 18, 2023
Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks! ❤️

The readme contains some unresolved link references by the way. You may want to resolve those.

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I do still recommend using unist-util-visit, much more powerful! feat: rehype-remove-images rehype-minify#47 (review)
  • you don’t have to return undefined explicitly I guess? Don’t return anything is the same?
  • Looks like index.d.ts is generated, so perhaps you can omit it from the Git history

doc/plugins.md Outdated Show resolved Hide resolved
@iloveitaly
Copy link
Contributor Author

  • I do still recommend using unist-util-visit, much more powerful

for me, it felt like this method was a bit more explicit / easier to understand. It's such a simple use case I figured it didn't matter much. Will look into this for the next one though!

doc/plugins.md Outdated
- [List of plugins](#list-of-plugins)
- [List of utilities](#list-of-utilities)
- [Use plugins](#use-plugins)
- [Create plugins](#create-plugins)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run npm install and npm test, that should reformat everything according to project style, or undo these changes manually? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@wooorm wooorm merged commit 7a95a44 into rehypejs:main Jul 29, 2023
2 checks passed
@wooorm wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done labels Jul 29, 2023
@wooorm
Copy link
Member

wooorm commented Jul 29, 2023

Thanks!

@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants