Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is that possible to make carton work for windows? #24

Closed
shelper opened this issue Apr 18, 2013 · 15 comments
Closed

is that possible to make carton work for windows? #24

shelper opened this issue Apr 18, 2013 · 15 comments

Comments

@shelper
Copy link

shelper commented Apr 18, 2013

i mean, can such package managing like carton be implemented purely in .el file? so that it shall work for emacs version for all OSs?

thanks!

@rejeep
Copy link
Member

rejeep commented Apr 18, 2013

Not impossible, I think. If not, there could always be one bash file and one batch file. I'm in the middle of a refactoring, let me try it out once that's done.

@joelmccracken
Copy link

I feel like many windows users also use cygwin, and thus have bash. Or am I wrong in thinking this?

@rejeep
Copy link
Member

rejeep commented Apr 30, 2013

Windows and Cygwin are completely unknown territories for me...

@tkf
Copy link
Contributor

tkf commented Jun 5, 2013

I think carton better implement almost everything in Emacs Lisp then bin/carton just can be something like ${EMACS:-emacs} --script path/to/carton-cli.el. That way, I imagine writing bin/carton.bat is not that difficult. Also user can just run carton-cli.el if script in bin does not work.

@joelmccracken
Copy link

Indeed; it also would make sense to be able to create cartons from within
emacs via emacs lisp, especially on windows

On Wed, Jun 5, 2013 at 10:32 AM, Takafumi Arakaki
notifications@github.comwrote:

I think carton better implement almost everything in Emacs Lisp then
bin/carton just can be something like ${EMACS:-emacs} --script
path/to/carton-cli.el. That way, I imagine writing bin/carton.bat is not
that difficult. Also user can just run carton-cli.el if script in bindoes not work.


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-18979953
.

@swsnr
Copy link
Contributor

swsnr commented Jun 5, 2013

@tkf A good idea.

@rejeep
Copy link
Member

rejeep commented Jun 5, 2013

@tkf Agreed. That way we also avoid writing BASH, which is quite painful if you ask me.

@rejeep rejeep mentioned this issue Jun 11, 2013
4 tasks
@ghost ghost assigned rejeep Jun 11, 2013
@rejeep
Copy link
Member

rejeep commented Jun 16, 2013

FYI, started working on this feature in branch bin-carton-in-emacs-lisp, see: https://github.com/rejeep/carton/tree/bin-carton-in-emacs-lisp

@swsnr
Copy link
Contributor

swsnr commented Jun 16, 2013

@rejeep I see that you are modifying carton.el, too, which brings me into some sort of dilemma, as I was just about to refactor it, too.

In Emacs trunk, package.el was heavily refactored, breaking almost any Carton command (interestingly, though, the public API changed somewhat, while all the internal API we used mostly stayed the same ;) ). I want to fix that by introducing a compatibility layer around package.el that wraps all API access to Carton.

@swsnr swsnr closed this as completed Jun 16, 2013
@rejeep
Copy link
Member

rejeep commented Jun 16, 2013

@rejeep I see that you are modifying carton.el, too, which brings me into some sort of dilemma, as I was just about to refactor it, too.

The changes you see in that branch are pretty much the ones that I need to do. Do you think there will be any conflicts?

In Emacs trunk, package.el was heavily refactored, breaking almost any Carton command (interestingly, though, the public API changed somewhat, while all the internal API we used mostly stayed the same ;) ). I want to fix that by introducing a compatibility layer around package.el that wraps all API access to Carton.

Any documented changes? :)

Sounds like a great idea, since we support many different versions.

@swsnr swsnr reopened this Jun 16, 2013
@swsnr
Copy link
Contributor

swsnr commented Jun 16, 2013

@rejeep Oops, sorry for closing the issue, pressed the wrong button accidentally.

If I base my work on master or v0.4-wip there will be conflicts. However, I roughly know which changes are needed, so if you ping me once your branch got somewhat stable, I can base my work upon it and merge it back into wip after your branch is merged. I think that's the best to avoid merge conflicts.

I can't start immediately anyway, because I hit two apparent bugs in package.el, see #14632 and #14633.

@rejeep
Copy link
Member

rejeep commented Jun 16, 2013

Allright, I'll do that!

@rejeep
Copy link
Member

rejeep commented Jul 2, 2013

Since I'm not a Windows user I wont be fixing this myself. If anyone wants to add Windows support, that would be awesome. What needs to be done is to create a batch file which basically is a copy of this (https://github.com/rejeep/carton/blob/v0.4-wip/bin/carton). And also add some notes in the README about how to use it.

Create pull request against the v0.4-wip branch.

@rejeep
Copy link
Member

rejeep commented Jul 15, 2013

Removing this from the v0.4-wip branch. Everything is prepared for someone to add a small batch script.

@rejeep
Copy link
Member

rejeep commented Oct 25, 2013

Closing this since none seems to be using Windows.

@rejeep rejeep closed this as completed Oct 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants