Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Encoding in ZIP Files #274

Closed
exc4l opened this issue Jun 21, 2023 · 2 comments
Closed

URL Encoding in ZIP Files #274

exc4l opened this issue Jun 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@exc4l
Copy link

exc4l commented Jun 21, 2023

To Reproduce
Steps to reproduce the behavior:

  1. Start the HFS.exe
  2. Add folders with japanese naming to the shared files
  3. Download said folders from localhost via the filepicker

Describe the bug
The original naming is as follows:
All You Need Is Kill / オール・ユー・ニード・イズ・キル 第01巻 / オール・ユー・ニード・イズ・キル_1_000a.png
So as you can see, there are folders with japanese names inside the main folder.
If you now use the file picker to download several folders on the same level, meaning you are inside "All you need is kill" and select the folders "オール・ユー・ニード・イズ・キル 第01巻 " and "オール・ユー・ニード・イズ・キル 第02巻 " and download them via the zip button, then the folder names inside the zip are the url encoded names i.e.
%E3%82%AA%E3%83%BC%E3%83%AB%E3%83%BB%E3%83%A6%E3%83%BC%E3%83%BB%E3%83%8B%E3%83%BC%E3%83%89%E3%83%BB%E3%82%A4%E3%82%BA%E3%83%BB%E3%82%AD%E3%83%AB%20%E7%AC%AC01%E5%B7%BB
Expected behavior
The files names should be correct

Environment (please complete the following information):

  • OS: Windows 10
  • HFS Version 0.45
  • Browser lastest chrome
@exc4l exc4l added the bug Something isn't working label Jun 21, 2023
@rejetto
Copy link
Owner

rejetto commented Jun 21, 2023

this should be fixed with 0.46.0 alpha7
can you confirm?

@exc4l
Copy link
Author

exc4l commented Jun 22, 2023

ye, alpha7 fixes the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants