Unable to download the metric logs from the nodes in the controller node.

[hanish520]

When we run the experiment on the remote nodes with metrics enabled, the controller node cannot download these logs.

This issue is because the path used in the host structure for the "data-dir" value is malformed. An example value for this value is "tmp/hotstuff.BpLnfgDs/data", missing a starting "/". The problem is the same for "test-dir."

I modified the below line to "src, err := iago.NewPathFromAbs("/"+iago.GetStringVar(host, "data-dir"))" and it is working.

hotstuff/internal/orchestration/deploy.go

Line 110 in 1c6a4ac

src, err := iago.NewPathFromAbs(iago.GetStringVar(host, "data-dir")) // assuming the dir variable was set earlier

I guess there is a better way to fix this.

[johningve]

Well, it's not really malformed as such. It's just that the io/fs package and hence also wrfs allow only unrooted paths (see ValidPath). The Deploy function was correctly removing the root prefix from the data directory, but the code in FetchData was handling the data directory path as if it was still a rooted path.

Fixed in 8a23ebf