Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Remove artsy auto-config dep, update auto pinned version #322

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

zephraph
Copy link
Collaborator

@zephraph zephraph commented Apr 7, 2021

This fixes the issues encountered in #275 where the deploy failed to increment the correct version.

I've implemented both fixes I suggested in the above issue. We both remove our dependency from Artsy's auto config (which lead to this original breakage) and bump the version of auto.

As a validation of this process, I've added the Trivial label which means this build should generate no release.

@zephraph zephraph added the Version: Trivial Changes only affect the internal API label Apr 7, 2021
@zephraph zephraph requested review from alloy and n1ru4l April 7, 2021 19:55
@zephraph zephraph self-assigned this Apr 7, 2021
@zephraph zephraph merged commit bc8ae04 into master Apr 7, 2021
@zephraph zephraph deleted the update-auto-version branch April 7, 2021 20:04
@zephraph
Copy link
Collaborator Author

zephraph commented Apr 7, 2021

Okay, confirmed it does the right thing.

@alloy
Copy link
Member

alloy commented Apr 7, 2021

🚀 PR was released in v14.0.0 🚀

@alloy alloy added the released label Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Version: Trivial Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants