Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Use optionalInputFields instead of inputFieldWhiteList #78

Merged
merged 3 commits into from
Dec 19, 2018

Conversation

koddsson
Copy link
Contributor

Hello 👋 !

This PR upgrades relay to version 2 and fixes the issue described in #73. I'm not sure how you'd prefer the branching here so this could go into master and be published under a RC/dev tag on npm if you'd like or be tracked in a 2.0.0 branch.

I also had to update immutable and jest to get the tests passing locally. I additionally took out the resolutions since relay doesn't seem to have been published there in some time.

Let me know what you think 😺

Fixes #73

@kastermester
Copy link
Contributor

Nice work! :)

I'm also not sure exactly how we should approach the upcoming 2.0 release. I am though, in general, in favour of keeping things as simple as possible. One solution I could see would be to leave this PR open until Relay 2.0 is released, then update the PR with the appropriate version numbers and merge it + release on NPM. Not sure what others think though.

@alloy Any ideas?

@alloy
Copy link
Member

alloy commented Dec 18, 2018

Awesome!

These API changes were already introduced in Relay 1.7 iirc, so imo the package should have a peer dependency on >= 1.7.0.

@alloy
Copy link
Member

alloy commented Dec 19, 2018

Ace, thanks 👍

I'll do an update of the example app and if that all pans out do a release.

@alloy alloy merged commit d30921c into relay-tools:master Dec 19, 2018
@koddsson koddsson deleted the fix-73 branch January 8, 2019 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Relay v2.0.0
4 participants