Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: not rendering URL to the end #366

Closed
scsargus opened this issue Feb 19, 2024 · 2 comments
Closed

bug: not rendering URL to the end #366

scsargus opened this issue Feb 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@scsargus
Copy link

Describe the bug
I try to monitor releases from the jFrog Artifactory website. I can find the releases on the page https://jfrog.com/download-legacy/?product=artifactory. I'm using the regex Artifactory\s+([0-9.]+) to find the release number, but the regex can not find a match.

In DEBUG mode, I can see

DEBUG: Artifactory (url_commands), Looking through: "\n<!doctype html>\n<html lang=\"en-US\">\n <head>\n <!--BE Head: Start-->\n \n<!-- be_ixf, sdk, gho-->\n<meta name=\"be:sdk\" content=\"php_sdk_1.5.12\" />\n<meta name=\"be:timer\" content=\"28ms\" />\n<meta name=\"be:orig_url\" content=\"https%3A%2F%2Fjfrog.com%2Fdownload-legacy%2F%3Fproduct%3Dartifactory%26installer%3Ddocker-compose\" />\n<meta name=\"be:norm_url\" content=\"https%3A%2F%2Fjfrog.com%2Fdownload-legacy%2F\" />\n<meta name=\"be:capsule_url\" content=\"https%3A%2F%2Fixfd1-api.bc0a.com%2Fapi%2Fixf%2F1.0.0%2Fget_capsule%2Ff00000000300631%2F01327722242\" />\n<meta name=\"be:api_dt\" content=\"py_2023;pm_11;pd_07;ph_12;pmh_56;p_epoch:1699361801986\" />\n<meta name=\"be:mod_dt\" content=\"py_2023;pm_11;pd_07;ph_12;pmh_56;p_epoch:1699361801986\" />\n<meta name=\"be:diag\" content=\"OjzKx7opDifusSb/aaknZnVCz+cOWbAN2cmmQjIVO4le2YwfIS8EgOBSbjwvUdltgWkMyTFmP++Dnf0WhFOQC9pbosvAJYeluxzcKGY9MwCzc0Nw4sAJyzZm7itCqEFRAPEGRtf181kFOwOc...

To Reproduce
Steps to reproduce the behavior:

  1. Configure a new application to monitor
  2. Use https://jfrog.com/download-legacy/?product=artifactory as the URL
  3. Use Artifactory\s+([0-9.]+) as regex pattern
  4. See the problem in DEBUG mode in syslog

Expected behavior
Argus should render the URL to the end, so the pattern can be found.

Additional context
I tried to wget the URL and I received the full content of the site. Maybe this helps...?
Thanks a lot for looking at this issue.
@scsargus scsargus added the bug Something isn't working label Feb 19, 2024
@JosephKav
Copy link
Collaborator

JosephKav commented Feb 20, 2024 •
edited
Loading

curl'ing that url gives 2.5MB of output, so don't really want to output all that, even in debug. I could change it to output everything, but just don't think there's much use in being able to scroll 40,000 lines as opposed to inspecting the url in the browser/curl

After looking at that URL in the browser, I got one-version "[^0-9]+([0-9.]+) to pickup the 6.16.0 version. Unless you want 7.77.5 - one-version[^0-9]+([0-9.]+)

(Your regex is based on the output visible to the user, not the HTML that Argus sees)

@scsargus
Copy link
Author

Thanks a lot. Your explanation was very helpful. I wasn't aware that Argus does not see the same as a user.
In the future I will inspect the urls with curl first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JosephKav @scsargus