Fix JSONWidget in newer Django versions #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In newer Django versions TextArea's 'build_attrs' method no longer accepts keyword arguments. The render method was modified to manually add the 'name' argument without using the build_attrs method.
Pull Request Test Coverage Report for Build 300
💛 - Coveralls |
lipoja
approved these changes
Feb 8, 2021
| @@ -46,7 +46,8 @@ def clean(self, value): | |||
| class JSONWidget(django.forms.widgets.Textarea): | |||
| def render(self, name, value, attrs=None, renderer=None): | |||
| if value is None: value = '' | |||
| final_attrs = self.build_attrs(attrs, name=name) | |||
| final_attrs = self.build_attrs(attrs) | |||
There was a problem hiding this comment.
According to the sources of Django, it should be possible to provide extra_attrs as the second argument:
Suggested change
| final_attrs = self.build_attrs(attrs) | |
| final_attrs = self.build_attrs(attrs, {"name": name}) |
But the proposed solution works as well so feel free to ignore my comment
Merged
|
Closing as obsoleted by #164 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer Django versions TextArea's 'build_attrs' method no longer
accepts keyword arguments. The render method was modified to manually
add the 'name' argument without using the build_attrs method.