Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreRelease with conventional changelog behaves unexpectedly #90

Closed
Blackclaws opened this issue May 29, 2024 · 4 comments · Fixed by #96
Closed

PreRelease with conventional changelog behaves unexpectedly #90

Blackclaws opened this issue May 29, 2024 · 4 comments · Fixed by #96

Comments

@Blackclaws
Copy link
Contributor

When using conventional changelog together with a prerelease branch it behaves unexpectedly.

Expectation

Commits on pre-release branch + Message + Expected Versions:

Start - N/A - 1.0.0
A - fix: fix something - 1.0.1-dev.0
B - fix: fix something - 1.0.1-dev.1
C - feat: new feature - 1.1.0-dev.0
D - fix: fix something - 1.1.0-dev.1 

Especially note the step from B -> C and C -> D.

Once we've incremented the minor version once from the base branch I expect that patch version no longer increments no matter what other fixes are pushed.

Reality

Without strictSemVer: true

Start - N/A - 1.0.0
A - fix: fix something - 1.0.1-dev.0
B - fix: fix something - 1.0.1-dev.1
C - feat: new feature - 1.0.1-dev.2
D - fix: fix something - 1.0.1-dev.3 

With strictSemVer: true

Start - N/A - 1.0.0
A - fix: fix something - 1.0.1-dev.0
B - fix: fix something - 1.0.2-dev.0
C - feat: new feature - 1.1.0-dev.0
D - fix: fix something - 1.1.1-dev.0

Both are wrong. Without strictSemVer I don't get an increase in the minor number on a feature and with it I get increases in the minor number and patch numbers all the time.

@JMMarchant
Copy link

Any update on this?

@webpro
Copy link
Contributor

webpro commented Aug 25, 2024

Thanks @Blackclaws, @micaelmbagira's PR has been released in v8.0.2-next.0, feel free to try it out. Would love to get your feedback before releasing v8.0.2.

@micaelmbagira
Copy link
Contributor

@webpro thanks for merging! I've just run some tests and it does work as expected. Also in the last few weeks, I was using this branch in another project and it's worked well 👌

@webpro
Copy link
Contributor

webpro commented Sep 11, 2024

This should be fixed in v8.0.2, thanks for your patience everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants