Fix invalid byte sequence in us ascii #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am using your branch, thanks for the fix. I hope it gets pulled in! |
|
I hope it gets pulled in! So that I can make it rake spec:rcov work in ruby 1.9.2 |
|
Just hit this issue aswell, would be nice to see it get pulled in for the next release. |
|
+1 |
1 similar comment
|
+1 |
|
Merging this, although to be honest doing a brute force_encoding seems like it could be dangerous down the road... |
rsanheim
added a commit
that referenced
this pull request
Aug 5, 2011
…S-ASCII Fix invalid byte sequence in us ascii
|
Note that Rcov will probably give you weird or inaccurate results with 1.9 -- use SimpleCov for 1.9 or something similar. |
|
Thanks for the pull. I have totally to agree that forcing wasn't the smartest idea. It was just a hotfix to get it back working. Using SimpleCov for 1.9 as well by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed #31 to work with ruby 1.9.
Cheers,
Alex