Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inHull(): tol argument not taken into account in some cases #5

Closed
scottkosty opened this issue Jan 8, 2021 · 2 comments
Closed

inHull(): tol argument not taken into account in some cases #5

scottkosty opened this issue Jan 8, 2021 · 2 comments

Comments

@scottkosty
Copy link
Contributor

I just tested current master (98adb11). One issue I noticed is that the value of the tol argument to inHull() is not taken into account in some cases. Here is an example:

library("gMOIP")
pt_ <- c(9.01, 9)
v_ <- matrix(c(3,3, 8,8, 9,9),
              byrow = TRUE,
	      ncol = 2)
inHull(pts = pt_, vertices = v_, tol = 1e10)

The above returns -1 for me, where I expect it to return 0 since the value for tol is large.

@relund
Copy link
Owner

relund commented Jan 9, 2021

I have fixed and updated the function documentation.

@relund relund closed this as completed in 3fc7851 Jan 9, 2021
@scottkosty
Copy link
Contributor Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants