Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port multibyte-string-p to rust #211

Merged
merged 3 commits into from Jun 20, 2017
Merged

Conversation

@shanavas786
Copy link
Collaborator

@shanavas786 shanavas786 commented Jun 19, 2017

No description provided.

@shanavas786 shanavas786 force-pushed the shanavas786:multibyte-string-p branch from 16d1451 to 63fa9f3 Jun 19, 2017
#[lisp_fn]
fn multibyte_string_p(object: LispObject) -> LispObject {
LispObject::from_bool(
object.is_string() && object.as_string_or_error().is_multibyte(),

This comment has been minimized.

@birkenfeld

birkenfeld Jun 19, 2017
Collaborator

Better: object.as_string().map_or(false, |s| s.is_multibyte())

@shanavas786
Copy link
Collaborator Author

@shanavas786 shanavas786 commented Jun 20, 2017

@birkenfeld Thanks, updated

Copy link
Collaborator

@Wilfred Wilfred left a comment

Looks good to me! :)

@Wilfred Wilfred merged commit b2e558e into remacs:master Jun 20, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Wilfred
Copy link
Collaborator

@Wilfred Wilfred commented Jun 20, 2017

Thanks.

@shanavas786 shanavas786 deleted the shanavas786:multibyte-string-p branch Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants