Port multibyte-string-p to rust #211
Merged
Conversation
shanavas786
force-pushed the
shanavas786:multibyte-string-p
branch
from
16d1451
to
63fa9f3
rust_src/src/strings.rs
Outdated
| #[lisp_fn] | ||
| fn multibyte_string_p(object: LispObject) -> LispObject { | ||
| LispObject::from_bool( | ||
| object.is_string() && object.as_string_or_error().is_multibyte(), |
birkenfeld
Jun 19, 2017
Collaborator
Better: object.as_string().map_or(false, |s| s.is_multibyte())
Better: object.as_string().map_or(false, |s| s.is_multibyte())
|
@birkenfeld Thanks, updated |
|
Looks good to me! :) |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.