fix(utilities): fix ELEMENTS_WITH_NO_TEXT_CHILDREN naming

remarkablemark · Aug 9, 2023 · 9ec5ba1 · 9ec5ba1
1 parent 1575740
commit 9ec5ba1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/utilities.js b/lib/utilities.js
@@ -99,7 +99,7 @@ var PRESERVE_CUSTOM_ATTRIBUTES = React.version.split('.')[0] >= 16;
 
 // Taken from
 // https://github.com/facebook/react/blob/cae635054e17a6f107a39d328649137b83f25972/packages/react-dom/src/client/validateDOMNesting.js#L213
-var ELEMENTS_WITH_TEXT_CHILDREN = new Set([
+var ELEMENTS_WITH_NO_TEXT_CHILDREN = new Set([
   'tr',
   'tbody',
   'thead',
@@ -118,7 +118,7 @@ var ELEMENTS_WITH_TEXT_CHILDREN = new Set([
  * @returns - Whether node can contain text nodes.
  */
 function canTextBeChildOfNode(node) {
-  return !ELEMENTS_WITH_TEXT_CHILDREN.has(node.name);
+  return !ELEMENTS_WITH_NO_TEXT_CHILDREN.has(node.name);
 }
 
 function returnFirstArg(arg) {
@@ -127,7 +127,7 @@ function returnFirstArg(arg) {
 
 module.exports = {
   PRESERVE_CUSTOM_ATTRIBUTES: PRESERVE_CUSTOM_ATTRIBUTES,
-  ELEMENTS_WITH_TEXT_CHILDREN: ELEMENTS_WITH_TEXT_CHILDREN,
+  ELEMENTS_WITH_NO_TEXT_CHILDREN: ELEMENTS_WITH_NO_TEXT_CHILDREN,
   invertObject: invertObject,
   isCustomComponent: isCustomComponent,
   setStyleProp: setStyleProp,

diff --git a/test/utilities.test.js b/test/utilities.test.js
@@ -1,7 +1,7 @@
 const React = require('react');
 const {
   PRESERVE_CUSTOM_ATTRIBUTES,
-  ELEMENTS_WITH_TEXT_CHILDREN,
+  ELEMENTS_WITH_NO_TEXT_CHILDREN,
   invertObject,
   isCustomComponent,
   setStyleProp,
@@ -141,7 +141,7 @@ describe('setStyleProp', () => {
 });
 
 describe('canTextBeChildOfNode', () => {
-  it.each(Array.from(ELEMENTS_WITH_TEXT_CHILDREN))(
+  it.each(Array.from(ELEMENTS_WITH_NO_TEXT_CHILDREN))(
     'returns false since text node cannot be child of %s',
     nodeName => {
       const node = {