-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 5.1.5 - multiple versions of @types/react causes typescript build errors #1320
Closed
captain-igloo opened this issue
Feb 19, 2024
· 6 comments
· Fixed by #1321 or #1322 · May be fixed by contentstack/contentstack-academy-playground#15 or contentstack/compass-starter-app#8
Closed
Version 5.1.5 - multiple versions of @types/react causes typescript build errors #1320
captain-igloo opened this issue
Feb 19, 2024
· 6 comments
· Fixed by #1321 or #1322 · May be fixed by contentstack/contentstack-academy-playground#15 or contentstack/compass-starter-app#8
Labels
bug
Something isn't working
Comments
@captain-igloo thanks for the find! Would you like to open a PR for the fix? I think your suggestion to use |
remarkablemark
added a commit
that referenced
this issue
Feb 19, 2024
4 tasks
PR for fix: #1321 |
Thanks @remarkablemark , it works now. |
@remarkablemark why is We have a few React apps that work as plugins of a legacy application that provides React 16 at runtime, so we can use 5.1.4 only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From version 5.1.5 I get errors building my typescript project due to multiple versions of @types/react. I'm not sure if this is a problem with html-react-parser or with @types/react.
See 78b7a8e
Expected Behavior
Should build correctly, possibly should have dependency on @types/react version ^18.2.55 instead of 18.2.55
Actual Behavior
Steps to Reproduce
git clone git@github.com:captain-igloo/html-react-parser-bug.git
cd html-react-parser-bug
npm ci
npm run build
Reproducible Demo
https://github.com/captain-igloo/html-react-parser-bug
Keywords
@types/react
The text was updated successfully, but these errors were encountered: