Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex bug on client parser #24

Merged
merged 2 commits into from Sep 27, 2016
Merged

Fix regex bug on client parser #24

merged 2 commits into from Sep 27, 2016

Commits on Sep 27, 2016

  1. Fix error for client-side parser by improving regex 

    For the client parser, when the first element of the HTML string
has attributes, the regex will improperly capture everything and
make the tag name invalid.

The fix is to ensure only the tag name is matched and whitespace
is trimmed.

Fixes #23
    @remarkablemark
    remarkablemark committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    2dfffb3 View commit details
    Browse the repository at this point in the history

  2. Add test to ensure client-side parser works with DOMParser 

    Confirm that for the client parser, if the first HTML element has
attributes, it should properly match only the tag name and no
longer throw an error.

Issue #23
    @remarkablemark
    remarkablemark committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    1bd17dd View commit details
    Browse the repository at this point in the history