Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot set properties of undefined (setting 'directiveAttributes') #13

Closed
4 tasks done
mbret opened this issue Sep 25, 2023 · 8 comments
Closed
4 tasks done
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@mbret
Copy link

mbret commented Sep 25, 2023

Initial checklist

Affected packages and versions

3.0.0

Link to runnable example

No response

Steps to reproduce

Need:

  • react project
  • react markdown library

write something like ::body2[content]{center}

as soon as me put a directive it crashes

Expected behavior

no crash

Actual behavior

image

image

Runtime

Node v17

Package manager

npm 8

OS

macOS

Build and bundle tools

Vite

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 25, 2023
@ChristianMurphy
Copy link
Member

Welcome @mbret! 👋
Sorry you ran into a spot of trouble.

A major version release is rolling out across all: unified, remark, rehype, and micromark packages.
This includes both type changes (static analysis error) and changes to the parser (potential runtime error) if the major versions are mismatched.

For now pin the version of remark-directive to the previous major until the new react-markdown major is released

@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
@github-actions

This comment has been minimized.

@ChristianMurphy
Copy link
Member

Duplicate of remarkjs/react-markdown#763

@github-actions
Copy link

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 25, 2023
@mbret
Copy link
Author

mbret commented Sep 25, 2023

Duplicate of remarkjs/react-markdown#763

indeed there is also a crash with latest version of rehype, which we are not using at the moment for the same reason.

That being said, is it really a duplicate ? it seems to be a different error no ?

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Sep 25, 2023

Bb offered some insight on that

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

The underlying cause is the same.
react-markdown needs a new major release.
The unified community does not need 30+ issues (and counting) to track one update.

We appreciate the excitement, please be patient.
It takes time to update 500+ packages (of which react-markdown is just one).

@nekorytaylor666
Copy link

any updates on this. have the same error.

@wooorm
Copy link
Member

wooorm commented Nov 9, 2023

Update your dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

4 participants