Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing whitespace is removed #16

Closed
4 tasks done
christianvoigt opened this issue May 8, 2024 · 4 comments
Closed
4 tasks done

Trailing whitespace is removed #16

christianvoigt opened this issue May 8, 2024 · 4 comments
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@christianvoigt
Copy link

christianvoigt commented May 8, 2024

Initial checklist

Affected packages and versions

remark-directive 3.0.0

Link to runnable example

example

Steps to reproduce

I am using remark-directives to mark up deleted and inserted text ranges within paragraphs (similar to critic markup). I use :del[old text ] and :ins[new text ] for this.

Currently, remark-directive does not respect empty spaces around the text. I saw #1 but think my case is slightly different as I use normal Markdown inside of the directive that should not be affected by putting it inside a directive. I don't see code fences as a viable workaround in this case.

Expected behavior

The trailing whitespace should be preserved.

Actual behavior

The trailing whitespace is removed.

Runtime

Node v17

Package manager

npm 8

OS

macOS

Build and bundle tools

Webpack

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels May 8, 2024
@wooorm
Copy link
Member

wooorm commented May 8, 2024

Hi!

Duplicate of micromark/micromark-extension-directive#22

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
@wooorm wooorm added the 👯 no/duplicate Déjà vu label May 8, 2024

This comment has been minimized.

Copy link

github-actions bot commented May 8, 2024

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

This comment was marked as resolved.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants