Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post processing $Disc #3297

Closed
Blackbear199 opened this issue Feb 16, 2022 · 6 comments
Closed

post processing $Disc #3297

Blackbear199 opened this issue Feb 16, 2022 · 6 comments

Comments

@Blackbear199
Copy link

Blackbear199 commented Feb 16, 2022

for file rename i have.
{$Disc}$Track.$Title

what i expect is..
single disc album
01.Title <== no disc number

multi disc album
101.Title
201.Title

i always get 101.Title even if its a single disc album

is this how it works? is there a way to have no $disc added for single disc albums?
i though adding $dsisc in curly braces would make it optional for single disc albums.

i cant find good documentation on this so guessing.

if this is how it works then maybe another file configuration line could be added for multi disc albums.
its setup like this in radarr.

@rembo10
Copy link
Owner

rembo10 commented Feb 18, 2022

Yeah I think it's expected behavior I guess since the disc number is 1.... But I think your're right. Are you on the develop branch? I added that option under Advanced -> Renaming Options

@rembo10
Copy link
Owner

rembo10 commented Feb 18, 2022

If you can test it out it would be very helpful

@Blackbear199
Copy link
Author

thanks,soon as it started rename..

2022-02-18 04:54:28 | ERROR | Uncaught exception: Traceback (most recent call last):File "/raiddata/0/module/Headphones/bin/headphones/headphones/logger.py", line 215, in new_runold_run(*args, **kwargs)File "/raid/data/module/Python3/sys/lib/python3.8/threading.py", line 870, in runself._target(*self._args, **self._kwargs)File "/raiddata/0/module/Headphones/bin/headphones/headphones/postprocessor.py", line 1302, in forcePostProcessverify(rgid, folder, forced=True, keep_original_folder=keep_original_folder)File "/raiddata/0/module/Headphones/bin/headphones/headphones/postprocessor.py", line 284, in verifydoPostProcessing(albumid, albumpath, release, tracks, downloaded_track_list, Kind,File "/raiddata/0/module/Headphones/bin/headphones/headphones/postprocessor.py", line 467, in doPostProcessingrenameFiles(albumpath, downloaded_track_list, release)File "/raiddata/0/module/Headphones/bin/headphones/headphones/postprocessor.py", line 1088, in renameFilesmd, from_metadata = metadata.file_metadata(File "/raiddata/0/module/Headphones/bin/headphones/headphones/metadata.py", line 250, in file_metadatares.add_items(iter(override_values.items()))File "/raiddata/0/module/Headphones/bin/headphones/headphones/metadata.py", line 52, in add_itemsself.setitem(key, value)File "/raiddata/0/module/Headphones/bin/headphones/headphones/metadata.py", line 43, in __setitem__self._lower.setitem(key.lower(), value)AttributeError: 'tuple' object has no attribute 'lower'

2022-02-18 04:54:28 | INFO | Renaming files

@rembo10
Copy link
Owner

rembo10 commented Feb 18, 2022

Sorry about that. Small typo. Should be fixed

@Blackbear199
Copy link
Author

everything looks perfect.
thanks
fyi before i asked about this i thought that maybe its simple reading the disc number from the metadata and adding whatevers there.
i checked a few albums and sure enough some were set to 1 for single disc albums so i set it to blank with mp3tag but it made no difference,it still added disc number.

thanks again for adding this.
this can be closed.

@rembo10
Copy link
Owner

rembo10 commented Feb 18, 2022

I think the beets mediafile library (which is used behind the scenes to read the metadata) automatically defaults to 1 as the discnumber / disctotal when there isn't any tags. I don't think that's the correct behavior, but I'm pretty sure that's what must be happening, since headphones isn't adding it.

@rembo10 rembo10 closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants