-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Her gem maintainer needed #324
Comments
hi remi. we're using her in a number of client gems here at practice fusion and i'd love to take a more active role in maintaining/enhancing it moving forward. i have a couple open PRs and we have a fork of the gem with some fixes/enhancements, mostly around consuming json_api which is what we are using as our standard. with the upcoming json-api 1.0 release, i believe the gem will def benefit from some further development in that area. in addition, having spent some time going through the source code, my feeling is that the configuration is admirably flexible, but all of those controls can also make it difficult to find the right combination of options to implement some of the more common cases. i believe that there are abstractions we could add/modify to better support some of these cases outside the box. her has been a big help to me in my professional life, so i'd like to give back. it fulfills a lot of the promise that many of us hoped activeresource would and i'd like to help the project continue to thrive. |
Had a look at that branch, @hubert, like some of the things I'm seeing there. +1 |
@hubert I sent you an email about a week ago regarding this and still no reply. Are you sure you’re still interested? |
hi remi. i just searched my email because i figured it got filtered by my gmail priority inbox settings, but i still don't see it :-( it's weird since i did get the latest notification. i am still interested. please let me know how you'd like to proceed. if you could resend your message and cc my work email, hhuang@practicefusion.com, so i'm sure to get it, i can answer whatever questions you might have. thanks! |
@hubert I sent the first email to hhuang@practicefusion.com but I just sent it again. Hopefully you’ll get it. Otherwise email me at my public email address 😄 |
Glad to see that things are moving 👍 |
@remiprev If you're still looking for maintainers, perhaps reference this issue in the README to raise visibility? |
Just wanted to ask to make sure but has a maintainer being identified and responsibilities handed off? |
@sambao21 good catch! |
@remiprev also maybe convert to an org? if you want a generic one, I can offer 'gemhome' |
hi @will-r. yes, this project is alive. i haven't had as much time to devote to it as would be ideal, but there's been a fair amount of work merged into master in addition to a relatively recent patch release. i've been delinquent on responding to the issues as my focus is to get all the open PRs addressed. i just msg'd you on your personal email where we can continue this discussion. |
Thanks, @hubert. |
I'd like to raise this again, its been 6 months since the last commit was merged, open pull requests are piled up, as are issues. @hubert hasn't been active anywhere on GH in months. Her is a terrific gem, easily the best in the space that I've come across. Would be a shame to watch it stagnate. |
I totally agree. |
Can be nice to have #399 merged. |
@remiprev I will reluctantly put my hat in the ring to maintain Her - it's invaluable to us at https://github.com/rooftopcms and https://github.com/errorstudio I'll need involvement from everyone else too though! Only have limited time. I suggest you/we follow the 'successful pull request gets commit access' model if you're too busy. Please give someone commit access to merge all the PRs |
Hi @Losco @giedriusr @hubert @bf4 @sambao21 @will-r - @remiprev has handed over the keys to the Her repo and I'll do my best to keep it maintained with the community's help. My colleague @Foxpaul will be involved too. The plan of action in the short term is to plough through the PRs and see which ones make sense to merge immediately; we would like to use the 'one PR merged = commit access' model, so we can all review stuff. Hope that suits. I'll close this issue now. |
awesome 👍 |
Sounds good, thanks for picking up the baton. On Fri, 30 Sep 2016 at 10:20 Giedrius Rimkus notifications@github.com
|
@edtjones just came back to Her after using it a few years ago and noticed PRs and Issues are still piling up, in particular around JSON::API support which is increasingly becoming popular. As one of the main maintainers in Faraday, I know how hard this is, so I've not come to complain but to offer some help and invite you to ask for help more openly if you need it. The last release for this gem was more than a year ago and it would be a shame for people to abandon it because of the stagnation in its development. I fell in love with Her when I used it and I think it's one of the best Faraday-based libraries out there, so I'd personally feel sorry to see it disappearing over time. |
Hi @iMacTia - sincere thanks for the message, and the challenge. I know that it's been a long time since anything much happened on the repo. We are using Her less at Error and so honestly I haven't been able to commit much time to working through the backlog of tickets. I know that @zacharywelch has done a much better job of keeping on top of things, but I think he's probaly busy too. So - please consider this a request for help! If you (or anyone else) feel equal to taking on some maintenance responsibilities we would be delighted to have the help. @remi is still the owner of the repo but quite happy to add committers. |
p.s. I'll re-open this ticket because it feels like a good time to bring in some more help. Hope that's ok with you @zacharywelch ? |
Thanks for getting back to me @edtjones and no worries, I completely understand! Priorities come and go and so do maintainers once libraries are not part of their everyday work. The same happened to me multiple times. As I said I really enjoyed using Her in the past, so I came back to it for a new project. Unfortunately, JSON:API is slowly taking over the REST HTTP scene and becoming increasingly popular, so I found myself stuck because of the lack of support from Her. Given my relative expertise with Faraday and since I'm working on this new project, I'd be happy to help out with maintenance and PRs review, but first I'd need to know if it's OK for the core team to add support for JSON:API, or if they believe that should be done separately (extension? Another gem? Fork?). I can't guarantee eternal support but as I said I feel in debt towards this library and I'd be happy to contribute and help if the core team's and mine interests are aligned 👍 |
... Several minutes later ... FWIW, there is spyke, which is a fork and rewrite! |
Hello all,
As you’ve probably noticed, I’m not actively participating in issues and pull requests in this repository anymore. First, I would like to say that I’m very sorry about that. Her is a project I love but I unfortunately don’t have the time/will anymore to maintain such a popular project with almost daily contributions (issues/PRs). I’m sorry I didn’t write this message earlier.
The fact is that I’m still using Her on a few projects at work, but mostly for basic data fetching and therefore there’s probably 90% of the code I don’t use, but that still needs bugfixes, improvements and new features.
So, I’m seeking your help. I know there are a lot of people using Her and probably people that know its whole source code better than me. People that have made pull requests, that maintain their own forks, who help other users with issues, etc.
I’m not sure if that’s the best way to find a new maintainer but let’s try this: reply to this issue only if you want to be the new maintainer for
her
. If you’d like, you can provide links to contributions and/or thoughts about where you’d like the project to be heading.The maintainer will be in charge (along with @pencil) of merging pull requests (also, saying no to pull requests 😉), fixing issues, adding new features, releasing new versions and picking new collaborators to help you with those tasks.
I don't really have a timeframe for this process, but hopefully we can make the switch in the next weeks and get this project right back on track!
Thank you!
The text was updated successfully, but these errors were encountered: