Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emp run lockup in 0.13 #1125

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Fix emp run lockup in 0.13 #1125

merged 1 commit into from
Apr 18, 2018

Commits on Apr 18, 2018

  1. Fix emp run lockup in 0.13 

    In 0.13, stdout/stderr were split using the stdcopy package.
Unfortunately, this doesn't play well with streamhttp.Heartbeat, which
sends null characters and causes the emp client to lockup.

This removes the heartbeat, since it's mostly unecessary, and causes
other weird side effects (e.g. if you're using tmux, the pain will get
"active" because it thinks there's output).

If using an ELB in front of the Empire daemon, the best thing to do is
set a high idle timeout (maximum is 60 minutes) to prevent emp run
sessions with no output from being killed. This is already the default
recommendation in docs/cloudformation.json.
    @ejholmes
    ejholmes committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    c8e060a View commit details
    Browse the repository at this point in the history