Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo 'increase memory on single node runs' #1567 #1609

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Mar 12, 2024

Purpose of this PR

Type of change

  • undo temporary fix

Checklist:

  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)
  • test_06-output.R fails. That is normally not part of make test, but I ran it anyway because the reporting was changes. Is probably caused by some recent changes in remind2. Fail log is /p/tmp/oliverr/remind/output/testOneRegi/log_output.txt.
### start generation of mif files at 2024-03-12 18:39:30
running reportMacroEconomy...
running reportTrade...
running reportPE...
running reportSE...
running reportFE...
running reportExtraction...
running reportCapacity...
running reportCapitalStock...
running reportEnergyInvestment...
running reportEmiAirPol...
running reportEmi...
Error in `.dimextract()`:
! subscript out of bounds ("seliqbio.fegas.indst.ETS", "seliqbio.fesos.indst.ETS", "seliqsyn.fegas.indst.ETS", "seliqsyn.fesos.indst.ETS", "sesobio.fegas.indst.ETS", "sesobio.fehos.indst.ETS", "seel.fegas.indst.ETS", "seel.fehos.indst.ETS", "seel.fesos.indst.ETS", "seh2.fegas.indst.ETS", "seh2.fehos.indst.ETS", "seh2.fesos.indst.ETS", "segabio.fehos.indst.ETS", "segabio.fesos.indst.ETS", "segasyn.fehos.indst.ETS", "segasyn.fesos.indst.ETS", "sehe.fegas.indst.ETS", "sehe.fehos.indst.ETS", "sehe.fesos.indst.ETS")
Backtrace:
    ▆
 1. └─remind2::convGDX2MIF(...)
 2.   ├─magclass::mbind(...)
 3.   └─remind2::reportEmi(gdx, output, regionSubsetList, t)
 4.     ├─vm_demFeSector[, , getNames(vm_demFENonEnergySector)]
 5.     └─vm_demFeSector[, , getNames(vm_demFENonEnergySector)]
 6.       └─magclass (local) .local(x, i, j, ..., drop = drop)
 7.         └─magclass:::.dimextract(x, k, 3, pmatch = pmatch, invert = invert)
Execution halted

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

The moment at happens again, I will work on fixing it.

[↑]

That did not take long :)

@fbenke-pik
Copy link
Contributor

On it

@fbenke-pik
Copy link
Contributor

Should be fixed with pik-piam/remind2#563

Copy link
Contributor

@fbenke-pik fbenke-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Did the test succeed this time?

@orichters orichters merged commit 016b612 into remindmodel:develop Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants