-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add matchDim helper #563
add matchDim helper #563
Conversation
R/reportEmi.R
Outdated
if (length(vm_demFENonEnergySector) == 0) { | ||
vm_demFENonEnergySector <- NULL | ||
} else { | ||
vm_demFENonEnergySector <- expandMagclass(vm_demFENonEnergySector, vm_demFeSector) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this helper also removes values from third dimension that are not in vm_demFeSector
, i am not sure if the trimming should be done here or only further down below in the context of the condition where it crashes (line 304)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks (probably you are still running buildLibrary?)
Maybe the proper place for this function would be in magclass
somewhere, but I actually don't care.
I will, it just takes forever for remind2 |
Adds a helper to reshape read in magclass objects to match a reference so subsequent operations do not create problems due to mismatched dimensions.
See also #549