add matchDim helper #563
Merged
add matchDim helper #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbenke-pik
requested review from
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q and
orichters
fbenke-pik
commented
Mar 13, 2024
R/reportEmi.R
Outdated
| if (length(vm_demFENonEnergySector) == 0) { | ||
| vm_demFENonEnergySector <- NULL | ||
| } else { | ||
| vm_demFENonEnergySector <- expandMagclass(vm_demFENonEnergySector, vm_demFeSector) |
There was a problem hiding this comment.
as this helper also removes values from third dimension that are not in vm_demFeSector, i am not sure if the trimming should be done here or only further down below in the context of the condition where it crashes (line 304)
There was a problem hiding this comment.
Here is good.
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
approved these changes
Mar 13, 2024
orichters
approved these changes
Mar 13, 2024
I will, it just takes forever for remind2 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper to reshape read in magclass objects to match a reference so subsequent operations do not create problems due to mismatched dimensions.
See also #549