Escape path variables #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks our api clients on some ids 😭 |
|
thanks for the contribution. couple questions:
|
|
@hubert it escapes primary key as you may see in the new added spec. |
|
@hubert wait, you mean rewrite all the tests to use |
marshall-lee
force-pushed
the
escape_variable_values
branch
from
a4e4fef
to
5480268
Compare
marshall-lee
force-pushed
the
escape_variable_values
branch
from
5480268
to
54f0dbe
Compare
|
updated |
|
Haha. I actually just meant the new specs but it's great that you did them all :-) I'll take a look at this when I get home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with parameters in a query string (
?a=1&b=blabla) Faraday escapes keys and values usingFaraday::Utils.escapehelper. But when parameters are passed in a path string (RESTful way) it doesn't happen so for example whenidvalue is something non-ascii.Since http path building is done on the Her side, it should be fixed here.