-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]: why need localforage, match-sorter, sort-by in the example in the tutorial? #11099
Comments
They're used by the contacts module you have to copy/paste in:
|
@brophdawg11 it worth noting (for beginners) that these packages are not needed for react-router itself |
This needs addressing somehow, either the gist needs updating or the docs need to call it out more clearly that it's not needed by the react router itself. Dependabot and other vulnerability scanners are screaming about prototype-pollution vulnerabilities in sort-by package, most of us included it because we were lead to believe it was needed by the tutorial. Obviously we can just remove them, but might be a good idea to make it clearer to people. |
We'd happily accept a PR to update the documentation! |
This commit will help prevent people thinking that sort-by, localforage and match-sorter are actually required by react-router-dom by following the tutorial page. See remix-run#11099.
Describe what's incorrect/missing in the documentation
I was reading the tutorial. there is a command:
But there is no usage of these packages (except react-router-dom itself) further
The text was updated successfully, but these errors were encountered: