Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No location.key on context #3956

Closed
mjackson opened this issue Sep 27, 2016 · 2 comments
Closed

No location.key on context #3956

mjackson opened this issue Sep 27, 2016 · 2 comments
Assignees
@mjackson
Labels
feature
Milestone
v4.0.0

Comments

@mjackson
Copy link
Member

Currently, createRouterLocation doesn't preserve the location.key. We should fix that.
@mjackson mjackson mentioned this issue Sep 27, 2016
Closed
@mjackson mjackson added this to the v4.0.0 milestone Sep 27, 2016
@mjackson mjackson changed the title [v4] No location.key on context No location.key on context Sep 27, 2016
@timdorr
Copy link
Member

timdorr commented Sep 27, 2016

Is key needed? I wonder if we can get around that by be careful to maintain the same location object instance and using === everywhere? That might be a hassle, but just a thought.

@mjackson
Copy link
Member Author

Yep, we need a key so we can save stuff to sessionStorage.

@mjackson mjackson self-assigned this Sep 27, 2016
ryanflorence added a commit that referenced this issue Oct 26, 2016
@ryanflorence
add location.key
90d4832 
fixes #3956
@jochenberger jochenberger mentioned this issue Oct 27, 2016
Closed
@nolawi nolawi mentioned this issue Aug 1, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjackson mjackson

Labels
feature
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
3 participants
@timdorr @mjackson @ryanflorence