Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to React 0.11.0 #87

Closed
WickyNilliams opened this issue Jul 18, 2014 · 10 comments
Closed

upgrade to React 0.11.0 #87

WickyNilliams opened this issue Jul 18, 2014 · 10 comments

Comments

@WickyNilliams
Copy link

Would be nice to have the react dependency bumped to 0.11.0.

Is it worth having a looser version dependency, to avoid this for each release? e.g. ">= 0.11.0"

@WickyNilliams
Copy link
Author

Tested locally and everything appears to work. Don't have time to PR, sorry

@bobeagan
Copy link
Contributor

See also a3d6e2a

@mjackson
Copy link
Member

I get the following npm error when I try npm install using React >=0.11.0:

npm ERR! peerinvalid The package react does not satisfy its siblings' peerDependencies requirements!

npm ERR! System Darwin 13.3.0
npm ERR! command "/Users/michael/.nvm/v0.10.29/bin/node" "/Users/michael/.nvm/v0.10.29/bin/npm" "install"
npm ERR! cwd /Users/michael/Projects/react-nested-router
npm ERR! node -v v0.10.29
npm ERR! npm -v 1.4.14
npm ERR! code EPEERINVALID
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/michael/Projects/react-nested-router/npm-debug.log
npm ERR! not ok code 0

Anybody know why react "does not satisfy its siblings' peerDependencies requirements"?

@ryanflorence
Copy link
Member

I do not understand peer dependencies, somebody said it would make upgrading easier for people so I merged it. do we only support >= 0.11?

@mjackson
Copy link
Member

I'd like to only support 0.11+. Anybody still on 0.10 already has their thing built and is already using v 0.2 of the router, right?

@WickyNilliams
Copy link
Author

After having thought it through, I'm not sure I was right in suggesting using >= 0.11.0. Per the semver spec, any version < 1.0.0 is considered unstable, so >= might be too relaxed?

Your call there of course :)

@ryanflorence
Copy link
Member

alright, >=0.11 sounds good.

(side note, wish people would release 1.0's and not be afraid of 2.0s and
11.0s for that matter, its just a number to tell me if something might have
broken)

(meanwhile ... my own repo is still not 1.0, SOON!)

On Fri, Jul 18, 2014 at 4:18 PM, Nick Williams notifications@github.com
wrote:

After having thought it through, I'm not sure I was right in suggesting
using >= 0.11.0. Per the semver spec, any version < 1.0.0 is considered
unstable, so >= might be too relaxed?

Your call there of course :)


Reply to this email directly or view it on GitHub
#87 (comment)
.

@ryanflorence
Copy link
Member

I'm moving this back to a normal dependency until I understand peer dependencies, but atm I can't install anything

@dmmalam
Copy link

dmmalam commented Jul 20, 2014

@rpflorence please push this to npm

@ryanflorence
Copy link
Member

I'll publish something tomorrow when I get a chance to double check some
things (decent API changes this next release), for now you can just npm install rpflorence/react-nested-router

On Sun, Jul 20, 2014 at 4:37 PM, Dharmesh Malam notifications@github.com
wrote:

@rpflorence https://github.com/rpflorence please push this to npm


Reply to this email directly or view it on GitHub
#87 (comment)
.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants