Don't override path in NavLink component. Fixes #6613 #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timdorr Added tests. Let me know of any feedback you might have. |
|
Rebased and added a similar refactoring as #6685 too. I can move that to it's own PR if you want to. |
MeiKatz
reviewed
Apr 3, 2019
Closed
|
Can you update the size snapshot? |
* Add tests for withRouter() inside NavLink
Same reasons as for withRouter: Less nesting, clearer error message.
|
@timdorr Rebased onto master and corrected the snapshots while doing so. |
|
Great! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments here.
I added some unit tests in NavLink-test and also removed the location override as a precaution for other interactions.