Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override path in NavLink component. Fixes #6613 #6623

Merged
merged 3 commits into from May 16, 2019
Merged

Don't override path in NavLink component. Fixes #6613 #6623

merged 3 commits into from May 16, 2019

Commits on May 16, 2019

  1. Don't override path in NavLink component. Fixes #6613 

    * Add tests for withRouter() inside NavLink
    @StringEpsilon
    StringEpsilon committed May 16, 2019
    Configuration menu
    Copy the full SHA
    0a2ab86 View commit details
    Browse the repository at this point in the history

  2. NavLink: Use RouterContext directly. 

    Same reasons as for withRouter: Less nesting, clearer error message.
    @StringEpsilon
    StringEpsilon committed May 16, 2019
    Configuration menu
    Copy the full SHA
    06d34ea View commit details
    Browse the repository at this point in the history

  3. NavLink: Remove obsolete import. Updated size snapshot

    @StringEpsilon
    StringEpsilon committed May 16, 2019
    Configuration menu
    Copy the full SHA
    ed92eb5 View commit details
    Browse the repository at this point in the history