Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare template small changes + esbuild fix #393

Closed
roelandmoors opened this issue Nov 18, 2021 · 2 comments
Closed

Cloudflare template small changes + esbuild fix #393

roelandmoors opened this issue Nov 18, 2021 · 2 comments

Comments

@roelandmoors
Copy link

The Cloudflare template has a webpack.config.js file, but since esbuild is used that file can be removed.

In the README I would also change Vercel to Cloudflare :-)

@roelandmoors
Copy link
Author

roelandmoors commented Nov 18, 2021

I would also add a parameter to the esbuild commands:
--main-fields=browser,module,main

Read more about this parameter here and here

I created an example

With that parameter you can use aws sdk 3

EDIT: added browser field after suggestion of @edmundhung

@roelandmoors roelandmoors changed the title Cloudflare template small changes Cloudflare template small changes + esbuild fix Nov 18, 2021
@machour
Copy link
Collaborator

machour commented Mar 15, 2022

Not applicable anymore I guess as the Cloudflare starters were rewritten.

@machour machour closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants