Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - ?_data= common problem since v1 #8993

Closed
miguelvelasquezdev opened this issue Mar 6, 2024 · 0 comments
Closed

[BUG] - ?_data= common problem since v1 #8993

miguelvelasquezdev opened this issue Mar 6, 2024 · 0 comments

Comments

@miguelvelasquezdev
Copy link

miguelvelasquezdev commented Mar 6, 2024

Reproduction

Just search https://kentcdodds.com/?_data=

related issues: #5199, #4564

both issues say that you can use handleError, but it just work when the trace comes from an error, but if your loader returns good, then handleError is worthless now.

that's bad because anyone can get sensible data with this trick.

System Info

npm run dev, yarn dev, pnpm dev

Used Package Manager

npm

Expected Behavior

should not expose loader data

Actual Behavior

any remix app with ?_data= in their url is exposing loader data, and if you don't set a loader function it triggers an error that you didn't set up a loader in your route

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant