Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-env listed as both dependency and dev-dependency in the express template #9668

Closed
arekmaz opened this issue Jun 28, 2024 · 2 comments · Fixed by #9680
Closed

cross-env listed as both dependency and dev-dependency in the express template #9668

arekmaz opened this issue Jun 28, 2024 · 2 comments · Fixed by #9680

Comments

@arekmaz
Copy link
Contributor

arekmaz commented Jun 28, 2024

Reproduction

https://github.com/remix-run/remix/blob/main/templates/express/package.json#L34

System Info

*

Used Package Manager

npm

Expected Behavior

cross-env ideally should be listed only once and as a normal dependency

Actual Behavior

I created a fresh fly-io app and after deployment I got "cross-env not found" error after running the default "npm start", after short investigation, it's listed 2 times in both "dependencies" and "devDependencies" section which apparently breaks it

after removing it from "devDependencies" and reinstalling modules I got it working

@brophdawg11
Copy link
Contributor

brophdawg11 commented Jun 28, 2024

Would you like to submit a PR to remove it from the devDependencies?

@arekmaz
Copy link
Contributor Author

arekmaz commented Jul 1, 2024

sure there it is

#9680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants