Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.0 / 1.16.1 / 1.17.0 : @remix-run/v1-route-convention do not save new route #23

Closed
1 task done
raskyer opened this issue Jun 7, 2023 · 3 comments
Closed
1 task done

Comments

@raskyer
Copy link

raskyer commented Jun 7, 2023

What version of Remix are you using?

1.17.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

  • Install 1.17.0
  • Configure v2_routeConvention with @remix-run/v1-route-convention
  • Run project
  • Add a route
  • After a very long rebuild time (issue already created before) the route isn't registered

Precision : Do not use the new dev server but the historic one.

Expected Behavior

The route is registered and accessible without full reload of dev server.

Actual Behavior

The route is not registered.

@MichaelDeBoey MichaelDeBoey transferred this issue from remix-run/remix Jun 7, 2023
@raskyer
Copy link
Author

raskyer commented Jul 14, 2023

Is there any update ?

@brophdawg11
Copy link
Contributor

Can you provide a reproduction? This works fine for me on a brand new app, you can see in the logs that I created a new file and it was picked up in 91ms.

Here's the remix.confg.js:

const { createRoutesFromFolders } = require("@remix-run/v1-route-convention");

/** @type {import('@remix-run/dev').AppConfig} */
module.exports = {
  ignoredRouteFiles: ["**/*"],
  serverModuleFormat: "cjs",
  future: {
    v2_dev: false,
    v2_errorBoundary: true,
    v2_headers: true,
    v2_meta: true,
    v2_normalizeFormMethod: true,
    v2_routeConvention: true,
  },
  routes: (defineRoutes) => createRoutesFromFolders(defineRoutes),
};
> remix dev


 💿  remix dev

 warn  The `remix dev` changing in v2
┃ You can use the `v2_dev` future flag to opt-in early.
┃ -> https://remix.run/docs/en/main/pages/v2#dev-server
┗
💿 Building...
💿 Rebuilt in 175ms
Remix App Server started at http://localhost:3000 (http://10.0.0.251:3000)
GET / 200 - - 55.512 ms
💿 File created: app/routes/page.tsx
💿 Rebuilding...
💿 Rebuilt in 91ms
GET / 200 - - 4.885 ms
GET /page 200 - - 11.220 ms

@brophdawg11 brophdawg11 removed their assignment Aug 10, 2023
@brophdawg11
Copy link
Contributor

I'm going to close this out due to the lack of a reproduction but if you can prepare one please let us know and we'll get this opened back up. Thanks!

@brophdawg11 brophdawg11 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants