Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for linking account listeners #92

Merged
merged 1 commit into from
Jun 9, 2018
Merged

Add doc for linking account listeners #92

merged 1 commit into from
Jun 9, 2018

Conversation

baudev
Copy link
Contributor

@baudev baudev commented Jun 8, 2018

Add documentation for the two following listeners:

  • accountLinked
  • accountUnlinked

Add documentation for the two following listeners:

- accountLinked
- accountUnlinked
@eXeDK eXeDK merged commit 2da5259 into remixz:master Jun 9, 2018
@baudev baudev deleted the baudev-patch-doc-account-linking-listeners branch June 11, 2018 07:58
@baudev
Copy link
Contributor Author

baudev commented Jun 11, 2018

Thanks for merging this PR @eXeDK !
Can you please update the tag v2.4.0 or consider adding a new one? Because the current one v2.4.0 goes back to 17 Oct 2016...

@eXeDK
Copy link
Collaborator

eXeDK commented Jun 15, 2018

Yep sure thing! I'll have a look at in the weekend @baudev

@baudev
Copy link
Contributor Author

baudev commented Jun 20, 2018

@eXeDK When you have a little time, if you could think about it please! There's no hurry.

@eXeDK
Copy link
Collaborator

eXeDK commented Jul 1, 2018

I'm looking at bumping the graph api from 2.6 to 2.7 just for a very quick fix before the API is deprecated. Then I think we should include it all in a v2.5.0.

Then do a more complete rewrite with the newest APIs afterwards. What are your thoughts on that @baudev ?

@baudev baudev restored the baudev-patch-doc-account-linking-listeners branch July 3, 2018 07:51
@baudev baudev deleted the baudev-patch-doc-account-linking-listeners branch July 3, 2018 07:53
@baudev
Copy link
Contributor Author

baudev commented Jul 3, 2018

Sorry I restored my branch by error. I confused with the PR #91.

Indeed, we should update the graph API for the v2.5.0. But why updating to the 2.7 and not directly to the 3.0?

@eXeDK
Copy link
Collaborator

eXeDK commented Jul 3, 2018

I ended up updating to 2.12 instead. I didn't want to bump to a new major version with my limited time. Version 2.12 is supported till 2020.

I also thought about the future life of this package. Is there still a need for this package? I see some more generic and more up to date packages out there now like: https://github.com/howdyai/botkit

Would it make more sense to point users to botkit instead?

@baudev
Copy link
Contributor Author

baudev commented Jul 3, 2018

I ended up updating to 2.12 instead

Perfect then! You can consequently release the v2.5.0?

Otherwise I think there is still an interest for this package. It's why I started contributing on it! This repository:

  • is really simple to use
  • provides all major functionalities
  • is easy to edit to your needs

@eXeDK
Copy link
Collaborator

eXeDK commented Jul 3, 2018

I already did on Sunday actually :-) https://www.npmjs.com/package/messenger-bot

Fair enough, then I'll help maintaining it as well.

@baudev
Copy link
Contributor Author

baudev commented Jul 3, 2018

Perfect thanks! I was only checking tags 😅

Fair enough, then I'll help maintaining it as well.

That's a good news to hear that!

@eXeDK
Copy link
Collaborator

eXeDK commented Jul 3, 2018

Ahh sorry, forgot to push the tag :D I created a new release as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants