Minor fixes: race condition, npm audit fixes, white space interfering with tests on Windows #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubNer
changed the title
https config wasn't respected in integration tests. [1] respect either http or https opts being defined by themselves [2] respect https opts if http is defined: previous change broke https
[2] fix paths in example/index.html
and oauth endpoints.
This reverts commit 4d3694a.
ignoring all of bin/test-suite-storage
|
Sorry guys if I'm making things confusing, but theses additional changes (4d3694a..6be492c) are pretty simple, confined to /example folder. Note that 87f65f0 is a revert of inadvertent changes to .gitignore regarding /bin folder, so .gitignore is back to what it was before I got my hands on things. 4d3694a are some notes I accidentally checked in that are reverted with 77620b6. They shouldn't show up in the diff. As for the rest of these commits, it's all in the /example folder. I made a youtube video: |
thornjad
requested changes
Apr 17, 2019
[1] fix typos in README.md [2] simplify promise in server init()
# Conflicts: # package-lock.json
|
I think this should have been merged after the last comment, no? |
|
@skddc Oh wow, totally forgot about this. I will merge, test, update deps and publish a new version. |
AngeloR
pushed a commit
to AngeloR/armadietto
that referenced
this pull request
May 20, 2021
… with tests on Windows (remotestorage#23) * Fix webfinger tests checking XML to play nice with whitespace * update dev dependencies as per audit * Fix race condition between ctro/init and boot * fix 'returns resource metadata as XML' test * don't hardcode port * FIX: change b8aad6d broke https in integration: passed unit testing but https config wasn't respected in integration tests. [1] respect either http or https opts being defined by themselves [2] respect https opts if http is defined: previous change broke https * Forgot to remove log * fixups to make ./example work * [oh] organizing thoughts * [1] starting `npm run dev` opens debug port [2] fix paths in example/index.html * code and logging panes added to example * Example application modified with the webfinger and oauth endpoints. * Example code finished * update readme * Revert "[oh] organizing thoughts" This reverts commit 4d3694a. * revert .gitignore back to previous version, not ignoring all of bin/test-suite-storage * fixup problems with hierarchical paths * As per review comments: [1] fix typos in README.md [2] simplify promise in server init()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] race condition constructing _httpServer/_httpsServer in ctor/init versus call to boot? Also inconsistent use of await on boot & stop in tests
[2] npm audit fixes (only dev dependencies)
[3] white space interfering with tests on Windows