Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find-file-hook overwrites magit keybindings #38

Closed
leoc opened this issue Apr 19, 2014 · 5 comments
Closed

Find-file-hook overwrites magit keybindings #38

leoc opened this issue Apr 19, 2014 · 5 comments

Comments

@leoc
Copy link

leoc commented Apr 19, 2014

I am using magit and when I require android-mode the magit-commit-buffer bindings are overwritten. I would suggest removing the built-in hooks and let the user create the hooks according to their setup.

@remvee
Copy link
Owner

remvee commented Apr 21, 2014

What version of magit are you using on what platform? This problem does not occur on my linux setup. Can we find a workaround? I like this approach.

@leoc
Copy link
Author

leoc commented Apr 24, 2014

I am using archlinux, emacs 24.3 and the latest packages from melpa.
I reconfigured the prefix to be C-c C-p and worked with that. Let me check again, when and how this issue occurs. :-)

@leoc
Copy link
Author

leoc commented Apr 24, 2014

The problem still occurs. I reduced everything to installing android-mode from MELPA and:

(require 'android-mode)

Whenever I am in the magit-commit-mode the android-mode-map overrides the C-c C-c binding.

@remvee
Copy link
Owner

remvee commented May 25, 2014

I had a similar problem with a prog-mode and added the android-mode-key-prefix customization for that. Mine is set to C-c C-a. Maybe that's a better default?

@remvee
Copy link
Owner

remvee commented Dec 10, 2014

See 67264a6

@remvee remvee closed this as completed Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants