-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servedir 0.1.1 #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should be `Content-Type`. Fix a bug where incorrectly-encoded paths would generate 404 errors.
+1 No reason not to pull this in. |
Awesome, thanks so much for pulling this in! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Remy,
I've made quite a few changes and improvements to
servedir
, and bumped the version number to 0.1.1.servedir
has been renamed toservedir.js
; the latter wasn't executable. I saw that you removed this earlier, though, so I can revert this if you'd like.Please let me know if you like the changes, and if there's anything else that you would like for me to add, fix, or revert. I've found
servedir
to be a capable replacement for my simple Ruby WEBRick script, so I'm more than happy to help out.