-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production bundle returns all 6000 icons even when I import only 1 icon #5
Comments
@rendinjast what do you think? |
@tofful I have same problem in react native. I think there is some problem with generation of modules. But didn't have time to look what's wrong. |
I'm aware of this issue but unfortunately I did not have access to my computer this month to working on it.
that's good idea. I might do that. |
wow great one @rendinjast thanks for pushing up the changes, it didn't address the issue as all icons are still being included in the bundle but at least I can see now a very significant file size reduction which is fantastic. Thank you very much for the prompt reply |
@rendinjast it would be great if you could add the ability to import every icon individually. like this: This will help reducing compile time in dev environment in frameworks like Nextjs I tested iconsax-react and it adds 2 seconds to compile time (In my environment). if i could import every icon individually compile time would be reduced. react-icons done this because of their huge amount of icons: https://www.npmjs.com/package/@react-icons/all-files |
And large bundle size problem has been fixed. Thanks!!! |
It looks like i can import icons individually in version 0.0.6 but I get typescript error.
|
Yes you can. import { CloudSunny } from "iconsax-react/dist/esm/CloudSunny"; |
@rendinjast this is the Typescript error that I got when I tried your recommended import syntax |
@tofful oh. its because when you import icon this way there is no type for that. create a declare module 'iconsax-react/dist/esm/*'; |
great @rendinjast thank you so much, I guess from my side I will just add a The last question from my side and then I believe we can safely close this issue. Is it too much hassle to do a
instead of just being able to import only via:
But I kind of found a workaround to use React.lazy without a default export, following this article, for those who are also wanting the same as me, this could be a solution: https://dev.to/iamandrewluca/react-lazy-without-default-export-4b65 and this one as well https://reactjs.org/docs/code-splitting.html#named-exports |
@tofful version 0.0.7. now you can import default icons. like:
the error is because you are using ECMAScript module. |
@rendinjast fantastic!! you rock! everything is working as expected. Perhaps the Readme.md file could be updated to reflect this new way of importing icons. |
with version |
As a dev, I would like to use iconsax library and I would like to use some of the icons, in my case, only one icon:
when I look at the generated bundle I expect to see one icon with the variant Bulk being generated, but instead, I see that all 6000 icons are included. This brings a lot of performance issues.
Looking at the Chrome DevTools I can see that the icons chunk takes 16 seconds to load when it is not in cache.
Solution
To include in the bundle only the icons used. Maybe the
import
should be something like thisThis way, we could even use it as lazy, please have a look at my simplified code:
The text was updated successfully, but these errors were encountered: