Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of presets, specifically the helpers: config preset #10896

Open
Tracked by #19289
HonkingGoose opened this issue Jul 19, 2021 · 1 comment
Open
Tracked by #19289

Inconsistent naming of presets, specifically the helpers: config preset #10896

HonkingGoose opened this issue Jul 19, 2021 · 1 comment
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jul 19, 2021 •
edited

What would you like Renovate to be able to do?

The sidebar of our docs page uses the singular form for the preset name: Included presets -> Helper Presets.
But the Helper Presets themselves use the plural form, for example: helpers:disableTypesNodeMajor.

All other presets use the singular form, like group:, monorepo: etc.

I don't know why we use the plural form for for the helpers: preset? Maybe there's a good reason that I'm missing.

Did you already have any implementation ideas?

Option 1: Rename side bar item from Helper Presets -> Helpers Presets, this way sidebar heading and preset prefix match again.

Option 2: rename Helper Presets from plural to singular form. So from helpers: to helper:. Keep sidebar as-is.
@HonkingGoose HonkingGoose added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Jul 19, 2021
@HonkingGoose HonkingGoose added type:refactor Refactoring or improving of existing code and removed type:feature Feature (new functionality) labels Oct 8, 2021
@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Nov 25, 2022
@rarkins
Copy link
Collaborator

rarkins commented Nov 25, 2022

We can rename from helpers: to helper: and retain a permanent redirect

@HonkingGoose HonkingGoose mentioned this issue Dec 7, 2022
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rarkins @HonkingGoose