Refactor tests that rely only on saved snapshots

[zharinov]

What would you like Renovate to be able to do?

It's easy to maintain incorrect behavior for pretty long periods, once snapshot is (re)written with bad data.
Snapshots are good when we have other assertions focused on particular aspects.
Otherwise, they may be abused as an easy way to escape mental effort required for writing better tests.

Did you already have any implementation ideas?

Identify and refactor such tests in small batches.

[zharinov]

@rarkins @viceice What do you think?

[viceice]

Sound good. 👍

[HonkingGoose]

I think we're good to start refactoring now we've identified the tests that rely on a single snapshot?

I've labeled this priority-2-important. The reasoning is that by doing the refactoring we can check if we have any bad behavior right now, and prevent future bad behavior from slipping through our test safety net. 😄 Feel free to assign a different priority if you like!

[rarkins]

I'm not sure you need to move 100% of them to explicit asserts. I think inline snapshots are much less likely to get "accidentally" broken than non-inline ones, so I think in some cases they would be good enough and quicker to migrate to. We should reserve snapshots only for big results.

[renovate-release]

🎉 This issue has been resolved in version 31.15.0 🎉

The release is available on:

• GitHub release
• 31.15.0

Your semantic-release bot 📦🚀