Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable WASAPI support #66

Closed
brainos233 opened this issue May 14, 2023 · 1 comment
Closed

Re-enable WASAPI support #66

brainos233 opened this issue May 14, 2023 · 1 comment

Comments

@brainos233
Copy link
Contributor

Hi, I noticed that 304cbf9 has disabled wasapi because of wine. I think wine users could set SDL_AUDIODRIVER to directsound to fix this, there is no need to completely disable wasapi in tasks/sdl2.py.

And although popping sounds have been fixed in config.fadeout_audio, according to libsdl-org/SDL#3001 using the SDL WASAPI driver is the recommended method to avoid this problem on Windows.

Can WASAPI be enabled again?
This was referenced May 17, 2023
Closed
Merged
@brainos233
Copy link
Contributor Author

@renpytom Any news? I've been testing for a week and I haven't experienced any problems. On my Windows 10, Ren'Py will use wasapi by default, it works better than directsound by setting environment SDL_AUDIODRIVER to directsound.

Also, the resampling problem of SDL2's wasapi audio driver appeared since 2.0.22, see libsdl-org/SDL#5538 and basically fixed in 2.26.0, since Ren'Py uses SDL 2.0.20, wasapi should work fine in Ren'Py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brainos233