New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor project and add Google Drive import&export #22
Conversation
Deleted TranslationExporter, TranslationImporter and SubTranslationConverter to only have a collection manager (TranslationManager) and a collection element (SubTranslation)
…ve values with commas and colons
…o preserve values with commas and colons" This reverts commit 137718e.
This reverts commit 915f3af.
Add oauth and google worksheets
@somebox @batiste could you have a look at this PR, code review it, and if everything is fine, merge it into master? You can have a look as well here https://github.com/AntoineInsa/i18n-docs (for badges, tests and documentation). The next step would be to update the gem on rubygems if that works for you. |
Hi @AntoineInsa. What an epic pull request. Thanks a lot for the effort you've put into this! I'm currently going to draft up a new release because we're lagging back quite a bit with the released version (additionally there is a bit of chaos going on with the versions). Two feedbacks:
|
i took the liberty and created a PR just for the module rename (which will hopefully make your work easier). |
@skaestle thanks a lot for coming back to me! I really liked the concept of i18n-docs and our project required to deal with a lot of different languages, and I didn't feel to use https://www.localeapp.com/, though it could be possible to integrate it as a different translation source (but not in a close future, at least for me!). Here's the translation tool comparison I did one year ago http://stackoverflow.com/questions/3201317/any-suggestion-for-ruby-on-rails-multilingual-translation-management I will be busy at work, but I really hope that we can work together to make i18n-docs usable and handy again, as its original intent. If you have time, I invite you to read my master README https://github.com/AntoineInsa/i18n-docs/blob/master/README.md to get an idea of what problematic I've tried to solve. I've created a new pull to address the 'google_drive_credentials' option, and some others small problems as well: AntoineInsa#10. I still have to remove the dependency to the config file if not existing. Let me know how you'd like to see the big PR split into smaller ones, and I'll try to adapt if possible, to facilitate discussion and integration. BTW, do you have owner access to the gem on rubygems? It will help to publish it there once we'll be done! Let's keep in touch and make it rock! |
@skaestle I've just noticed new code on https://github.com/local-ch/i18n-docs/releases/tag/v0.0.10 that I haven't seen before. I'll see if I can solve the conflicts, and I'll keep you posted. |
It will use the same structure, wherever the options are coming from (ruby_options, ENV, config).
@AntoineInsa thanks for the update. yeah. sorry to spring all the new code on the project. I needed to integrate a branch we had used privately. necessary evil to get back on track with this gem. About splitting this PR up:
HTH |
Fix/special characters
This looks awesome. Any chance of getting this merged in? If not, @AntoineInsa how is your branch working for you? Which version of Rails have you tested it with etc.? |
@elsurudo my branch is working like a charm, we're still using it at work, for both Rails (still 3 though, not sure for 4), and non Rails projects (see below). |
Hey @AntoineInsa is this still a thing? There are still some conflicts. |
Closing this due to inactivity. |
Hi there,
I've found your gem pretty good, and I really like its concept. I wanted to add it to one of my project, but as Google Docs was replace by Google Drive, they changed their API and it was not possible to make any download.
Here's what I did
And more
You could give the gem a try by adding the following to your gemfile:
And here is what the new translations.yml looks like. Note that you can specify
google-drive
spreadsheet titles directly, without any url. You need to specify as well a way to authenticate to google, either by username/password or by oauth.or using oauth (see https://github.com/gimite/google-drive-ruby#how-to-use for more details)
I hope that even if I did a mess and move things around, I've still helped to go forward.
Let me know what you think about it. If you think it is still possible to merge it with modifications, I'll be happy to do them. On the other hand, if this version is too far from what you expect the gem to do, I can continue on my own and publish myself, but it would to bad.
Hope to hear from you, and have a good week-end!