Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Disabling relative path does not work #106

Closed
reobin opened this issue Feb 15, 2021 · 4 comments
Closed

bug: Disabling relative path does not work #106

reobin opened this issue Feb 15, 2021 · 4 comments

Comments

@reobin
Copy link
Owner

reobin commented Feb 15, 2021

As mentioned in #104, there seems to be a problem with the TYPEWRITTEN_RELATIVE_PATH option.

@reobin
Copy link
Owner Author

reobin commented Feb 15, 2021

Hi @CrystalJewell! can you help me feed this issue with more information?

@CrystalJewell
Copy link
Contributor

@reobin Sorry I have been crazy busy this week. I'm circling back to this today. I'll get screenshots and detail what I'm seeing ASAP. The TL:DR is that it appears that TYPEWRITTEN_RELATIVE_PATH="off" is hitting TYPEWRITTEN_RELATIVE_PATH="home" instead.

@CrystalJewell
Copy link
Contributor

CrystalJewell commented Feb 19, 2021

After getting screenshots of the behavior, it actually looks like pure is ignoring the TYPEWRITTEN_RELATIVE_PATH variable altogether.

TYPEWRITTEN_PROMPT_LAYOUT="pure"
No Relative path export Screen Shot 2021-02-19 at 1 51 14 PM
TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 1 52 23 PM
TYPEWRITTEN_RELATIVE_PATH="git" Screen Shot 2021-02-19 at 1 53 30 PM
TYPEWRITTEN_RELATIVE_PATH="home" Screen Shot 2021-02-19 at 1 54 43 PM
TYPEWRITTEN_RELATIVE_PATH="adaptave" Screen Shot 2021-02-19 at 1 52 23 PM
TYPEWRITTEN_PROMPT_LAYOUT="half-pure"
No Relative path export Screen Shot 2021-02-19 at 1 59 02 PM
TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 00 25 PM
TYPEWRITTEN_PROMPT_LAYOUT="singleline" & TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 02 27 PM
TYPEWRITTEN_PROMPT_LAYOUT="singleline_verbose" & TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 03 44 PM
TYPEWRITTEN_PROMPT_LAYOUT="multiline" & TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 04 38 PM

@reobin
Copy link
Owner Author

reobin commented Feb 19, 2021

Thank you for the updates @CrystalJewell !

That was a design decision, actually. Sorry for the confusion! The original Pure prompt displays the whole path that is relative to home. Since the pure layout of typewritten is inspired by the original Pure, I made it ignore TYPEWRITTEN_RELATIVE_PATH variable.

Now that I think about it, there is no reason for it to do that. It would be a nice and easy feature to add to typewritten.

I'll add the feature request in another issue and close this one.

Thank you @CrystalJewell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants