Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tangent attributes #4

Open
andrewvarga opened this issue Feb 21, 2024 · 0 comments
Open

Support tangent attributes #4

andrewvarga opened this issue Feb 21, 2024 · 0 comments

Comments

@andrewvarga
Copy link

Hi! Thanks for this library!
I played with it for a hobby project using in combination with lightmap-baker and I found that if the model has tangent attributes then those are not updated and so cause WebGL drawing errors (because the attribute count changes for position, normal and texture attributes but not for tangents..

I suspect the changes would be around this line..?

if(m.vertex.normals) mesh.setAttribute('normal', new this.THREE.BufferAttribute(m.vertex.normals, 3, true));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant