Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKR E3 Mini: fix build failure & example config filenames #1003

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

alexsomesan
Copy link
Contributor

Currently the build for SKR E2 mini fails on Linux systems because the src/Repetier/src/boards/STM32F1/boards/skr_mini_e3_v1_2/skr_startup_stm32f103xe.s file having a lower-case extension.

It turns out PlatformIO cares about case on the extension when deciding which build tool will handle the file. Explained here: platformio/platform-ststm32#332

Also renames Configuration_io_Mini_E3.h to align it to other SampleSystems entries.

@AbsoluteCatalyst
Copy link

Oh whoops, my bad on the Configuration_io_Mini_E3.h name. Forgot to rename it before I made the pull. Thanks!

@alexsomesan
Copy link
Contributor Author

No worries, it was easy to spot and fix.

Thanks for putting together the sample configuration for at least one SKR. It's a huge progress boost for me in getting these boards to work with Repetier.

Oh whoops, my bad on the Configuration_io_Mini_E3.h name. Forgot to rename it before I made the pull. Thanks!

@AbsoluteCatalyst
Copy link

Ah wait, you might want to merge with the latest dev2 and rebase this, repetier actually just pushed a commit fixing that same file extension lower-case issue just a few minutes ago. (He also moved the files to a new location)
I don't believe he fixed the samplesystem Configuration_io_Mini_E3 filename though.
See: 5faf381

@alexsomesan
Copy link
Contributor Author

Can confirm 5faf381 fixes the startup code issue. I removed that change from this PR.

@AbsoluteCatalyst
Copy link

Sweet.

PS. If you happen to be running this on an ender 3, would you mind running a PID tune on the ender's bed heater and sharing the Kp Ki kD values?
I couldn't get ahold of anyone with one and I don't have that bed heater, so the sample's bed PID settings are wrong.

@alexsomesan
Copy link
Contributor Author

Actually, I don't have an Ender 3 either. I plan to run it on a self-built HypercubeEvo (CoreXY). It has an MK42 bed.

@alexsomesan
Copy link
Contributor Author

We could post a binary on the Ender 3 Facebook group in case someone wants to do the PID and contribute. Would also help with awareness about Repetier supporting these boards now.

@AbsoluteCatalyst
Copy link

I don't have a facebook account to post with, unfortunately. :(
Great idea though, and I'd definitely like to increase more awareness for V2. I think creality recently got a discord too.

I'll be adding another SKR E3 Mini V2.0 board variant sometime tonight or tomorrow since I got my hands on one.
It's not too different.

I do hope Repetier gets a chance to fix the invalid cert on the V2 doc site sometime soon. Chrome does it's big spooky warning.

@alexsomesan
Copy link
Contributor Author

I'll post the binary to FB then, once I test the build to make sure all features of the board work.

I was just going through the https://docfirmwarev2.repetier.com site and Firefox is happy with it. It has a valid "Let's Encrypt" issued cert. Is that what you were referring to?

@AbsoluteCatalyst
Copy link

I believe it's because the cert was made for the docfirmwarev2 subdomain.
If you go directly to https://repetier.com/ instead you'll get the certificate error. (At least I do)

@alexsomesan
Copy link
Contributor Author

WOW, yeah! You're right. It's still scary that way.

I didn't notice it until now since I just followed the link from the top of README here on github.

@repetier repetier merged commit 9ec373b into repetier:dev2 Oct 20, 2020
@repetier
Copy link
Owner

Did not know repetier.com maps to that. Not planned. Correct url for docs is https://docfirmwarev2.repetier.com/ and there certificate is correct.

@AbsoluteCatalyst
Copy link

Oh I see, just noticed www.repetier.com links to your main site instead too. I saved the wrong url at some point.
I'll update the v2 doc links I left inside the E3 sample configurations real quick.

@alexsomesan alexsomesan deleted the fix-skr-e3-mini-build branch October 20, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants