Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"config" metadata on experiment is broken #492

Open
bfirsh opened this issue Jan 14, 2021 · 0 comments
Open

"config" metadata on experiment is broken #492

bfirsh opened this issue Jan 14, 2021 · 0 comments
Labels
help wanted Extra attention is needed priority/low type/bug Something isn't working

Comments

@bfirsh
Copy link
Member

bfirsh commented Jan 14, 2021

Problem

This replicate.yaml:

repository: file://.replicate/

Produces this in the experiment metadata:

{"repository": "file:///private/var/folders/mf/qgf_gk717c1dfmy58rnsv2500000gn/T/tmpzybw7jt4/.replicate", "storage": ""}

It should be the same thing as what's in replicate.yaml.

Solution

When creating a project in project.go, it attempts to re-create a Config object. It should instead pass round the raw Config object so we can put that in the metadata.

It should also not include the deprecated storage option if it is blank.

@bfirsh bfirsh added type/bug Something isn't working help wanted Extra attention is needed priority/low labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed priority/low type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant