[protocolv2] Remove the concept of close requests #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Came up as part of the giga review for #127.
It's just one more concept that's unneeded. Instead of close requests, streams can listen to the closes on the other pipe and decided if they want to close then. Alternatively (for upload and stream procs), service implementers can implement a user-space close-request mechanisms. The only thing that this leaves open is in subscriptions clients have no way of signaling disinterest in the data, in which case they should just abort the stream.
FWIW this is how gRPC works.
What changed
Remove close request, swap with aborts in tests where relevant.