[protocolv2] Use new simpler readable and writable interfaces #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masad-frost
commented
Aug 1, 2024
| }); | ||
| resReader.onClose(() => { | ||
| >(); | ||
| const closeReadable = () => { |
There was a problem hiding this comment.
not a fan of this, but will be better once i move it to "proc stream" to its own class
|
I'll be merging this since it's a simple switch-aroo, review at your own pace. It doesn't address any of the comments on the base PR, so there will be other follow ups. I'll also rename "reader" and "writer" in a separate PR. |
masad-frost
added a commit
that referenced
this pull request
Aug 1, 2024
Just a simple follow up to #250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow up on #249 to actually use the new interfaces. Removed extra refactor done in #249 that merges the interfaces as that proved to be a challenging API (un-yak-shave 🙅 🐃)
What changed
Versioning