-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure not being reported up when last keyword passes #39
Comments
@skinny-b it can be fixed on the agent side. But, firstly, I'd like to ask @DzmitryHumianiuk about limitations from the application side. Is that kind of expected behavior when TestSuite takes into account the result of the last nested element only? |
If you populate status in
if you finish parent (suite) level before child (test), then child will receive status of parent, and in case of finishRQ will have status for child, it will be updates afterwards. hope this helps, |
@iivanou in version 5 we have reportportal/reportportal#275 for this. we can have a call next week with dev team, to discuss the way it works |
@DzmitryHumianiuk oke, let's do this. Getting back to the issue. Our problem is hidden in line 204. We consider the last element of the self.stack being the parent_id for the current item that makes us unable to control nested structures. We can't modify this line without breaking other Python agents. |
@skinny-b could you please run the same test suite against the v5.0 of RP? https://beta.demo.reportportal.io/ |
@iivanou does async capabilities in RPv5 will help to solve it? now you can create tree structure of elements on client side, by generating item |
@DzmitryHumianiuk it should, definitely. But it will require RP to be upgraded to V5. |
sure, |
I don't believe I can test it on V5 yet, once reportportal/reportportal#715 is resolved we can deploy it to test it further. |
@skinny-b It's already deployed for everyone: https://beta.demo.reportportal.io/. You can use your GitHub account to log in. |
@skinny-b Unfortunately, we have to change a common client and agents to make use of new async reporting introduce in RP v5. I'll let u know when a list of necessary changes is ready to go. |
Tried with both #40 and reportportal/client-Python#62 and got the same result as before: #39 (comment) |
Ok, in this case, I would consider reportportal/reportportal#275 feature is not working by design.
In our case, we have at least one failed children, but RP still reports all passed. @DzmitryHumianiuk, test items with type "STEP" are still being reported with method type "TEST". What type should be set for nested steps? I couldn't find this information at https://beta.demo.reportportal.io/ui/#api. |
@Yumfriez Vanya, could you please help? Could you please add a link to the dev guide for Nested steps |
@iivanou it should be Nested step marker is parameter:
|
@iivanou Hi is there any update on this issue. kindly let me know when are we planning to fix this issue or how can I over come this. Thanks for your time |
This issue will be fixed in new agents that will support RP version 5 only. |
@iivanou Thank you. |
Was running tests that have an intermittent failure and wasn't seeing the failure being reported to the top level. It shows reduced testcase count, as test didn't complete, but no failures. With the help of @iivanou (thank you) were able to determine that the ending keyword pass seems to be the culprit.
Using the following:
(venv) bash-4.2$ pip list | grep report
pytest-reportportal 1.0.8
reportportal-client 3.2.3
robotframework-reportportal 3.1.0
Last image shows the red ones as failed and the last Capture as pass.
The text was updated successfully, but these errors were encountered: