Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seems like it doesn't apply labels? #124

Closed
tunnckoCore opened this issue Jun 17, 2019 · 3 comments
Closed

Seems like it doesn't apply labels? #124

tunnckoCore opened this issue Jun 17, 2019 · 3 comments

Comments

@tunnckoCore
Copy link
Contributor

tunnckoCore commented Jun 17, 2019 •
edited
Loading

I have this config

Am I missing something or what? :) I also deleted all of the old ones, because I don't care and don't want to rename them.

One more question is popping up... How can we get notified if the config is invalid/broken or whatever? Would be good to open issues when find error.
@tunnckoCore
Copy link
Contributor Author

Oooh, or it is because I include # for the color? We should definitely handle that, because editors can colorize that I want it.

@tunnckoCore
Copy link
Contributor Author

tunnckoCore commented Jun 17, 2019 •
edited
Loading

Mm nope, it's because plugins/labels.js don't have sync() method. I'll PR.

@tunnckoCore
Copy link
Contributor Author

tunnckoCore commented Jun 17, 2019 •
edited
Loading

Ooooh, I missed that it extends Diffable and there's the sync().

Right. So we just need to support the #. It's another issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tunnckoCore