Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for renaming/moving files #6

Merged
merged 6 commits into from
Jan 27, 2015

Conversation

witsch
Copy link
Contributor

@witsch witsch commented Jan 21, 2015

for now i've created a separate test class as i didn't really grok the reason for the extra DummyDataManager. however, if the patch looks alright (and somebody tells me what the dummy manager is for :)), i'll be happy to add a rename_file there as well…

@tseaver
Copy link
Member

tseaver commented Jan 21, 2015

testing.DummyDataManager exists to ease testing of dependent apps. It should support the same API as `manager.FileSafeDataManager', but allow for easy introspection of the changes induced by the app's tests.

@witsch
Copy link
Contributor Author

witsch commented Jan 27, 2015

On 21 Jan 2015, at 21:03, Tres Seaver notifications@github.com wrote:

testing.DummyDataManager exists to ease testing of dependent apps. It should support the same API as `manager.FileSafeDataManager', but allow for easy introspection of the changes induced by the app's tests.

ah, now it makes sense — thank you. i’ve updated the dummy manager in 7e3f477.

@witsch
Copy link
Contributor Author

witsch commented Jan 27, 2015

On 27 Jan 2015, at 11:51, Andreas Zeidler az@zitc.de wrote:

ah, now it makes sense — thank you. i’ve updated the dummy manager in 7e3f477.

i guess i should have actually read the docs — i only grep’ed for DummyDataManager… :)

@tseaver
Copy link
Member

tseaver commented Jan 27, 2015

@wichert LGTM.

wichert added a commit that referenced this pull request Jan 27, 2015
add support for renaming/moving files
@wichert wichert merged commit 26363fd into repoze:master Jan 27, 2015
@wichert
Copy link
Contributor

wichert commented Jan 27, 2015

@witsch can you sign the contributors file as well?

wichert added a commit that referenced this pull request Jan 27, 2015
@witsch witsch mentioned this pull request Jan 27, 2015
witsch added a commit to pyfidelity/repoze.filesafe that referenced this pull request Jan 28, 2015
@wichert
Copy link
Contributor

wichert commented May 1, 2015

FYI this has now been released with version 2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants